From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 03DD6BB5D6
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:11:41 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id DAD651F988
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:11:40 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:11:36 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B23D441DD1
 for <pve-devel@lists.proxmox.com>; Mon, 25 Mar 2024 09:11:36 +0100 (CET)
Message-ID: <fa3fded3-6404-42f7-a6cf-02dfcc023856@proxmox.com>
Date: Mon, 25 Mar 2024 09:11:35 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Alexander Zeidler <a.zeidler@proxmox.com>
References: <20240322135933.164404-1-a.zeidler@proxmox.com>
 <20240322135933.164404-5-a.zeidler@proxmox.com>
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20240322135933.164404-5-a.zeidler@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.209 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 POISEN_SPAM_PILL          0.1 Meta: its spam
 POISEN_SPAM_PILL_1        0.1 random spam to be learned in bayes
 POISEN_SPAM_PILL_3        0.1 random spam to be learned in bayes
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster
 info to more appropriate sections
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 25 Mar 2024 08:11:41 -0000

And why are those more appropriate? Both fit's the general "always important"
section, so even though they fit the section you moved them too, they also
fit the general one, so some actual reasoning here would be good..

On 22/03/2024 14:59, Alexander Zeidler wrote:
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
>  PVE/Report.pm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 2c2a5e12..505629c7 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -41,8 +41,6 @@ my $init_report_cmds = sub {
>  		'cat /etc/apt/sources.list',
>  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.list') },
>  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.sources') },
> -		'lscpu',
> -		'pvesh get /cluster/resources --type node --output-format=yaml',
>  	    ],
>  	},
>  	'system-load' => {
> @@ -96,6 +94,7 @@ my $init_report_cmds = sub {
>  	    order => 60,
>  	    cmds => [
>  		'pvecm nodes',
> +		'pvesh get /cluster/resources --type node --output-format=yaml',
>  		'pvecm status',
>  		'cat /etc/pve/corosync.conf 2>/dev/null',
>  		'ha-manager status',
> @@ -106,6 +105,7 @@ my $init_report_cmds = sub {
>  	    order => 70,
>  	    cmds => [
>  		'dmidecode -t bios',
> +		'lscpu',
>  		'lspci -nnk',
>  	    ],
>  	},