From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 81E3CBB67E for ; Mon, 25 Mar 2024 11:49:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 589232047 for ; Mon, 25 Mar 2024 11:49:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 25 Mar 2024 11:49:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7735041E3E for ; Mon, 25 Mar 2024 11:49:52 +0100 (CET) Message-ID: Date: Mon, 25 Mar 2024 11:49:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US From: Fiona Ebner To: Proxmox VE development discussion , Filip Schauer Reply-To: Proxmox VE development discussion References: <20240108135456.74684-1-f.schauer@proxmox.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] fix #5160: fix move_mount regression for mount point hotplug X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2024 10:49:53 -0000 Am 25.03.24 um 11:29 schrieb Fiona Ebner: > > After shutdown+start, the hotplug worked as expected. Played around a > bit more and something strange happened with LVM as the storage: While > it worked the first time, when I shut down the container, detached the > mount point, started again and then tried to hot-plug, I got: > mp1: unable to hotplug mp1: command 'mount /dev/lvm/vm-129-disk-1 > /var/lib/lxc/.pve-staged-mounts/mp1' failed: exit code 32 > > Doesn't seem to happen with ZFS or directory storage and starting with > the mount point pre-attached also worked fine with previously written > files still there. > > Also booted into 6.2.16-20-pve, installed unpatched pve-container and it > seems the issue was already present then. > After looking into this, it's likely because the LV is deactivated after the shutdown. Apparently we're missing the activate_volume() call before doing a hotplug.