From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1B7D61FF380 for ; Fri, 19 Apr 2024 10:19:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CE7816D4; Fri, 19 Apr 2024 10:19:58 +0200 (CEST) Message-ID: Date: Fri, 19 Apr 2024 10:19:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Lukas Wagner References: <20240409132555.364926-1-l.wagner@proxmox.com> <20240409132555.364926-6-l.wagner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240409132555.364926-6-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox 05/19] notify: make the `mail-forwarder` feature depend on proxmox-sys X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 09.04.24 um 15:25 schrieb Lukas Wagner: > It uses proxmox_sys::nodename - the dep is needed, otherwise the code > does not compile in some feature flag permutations. > > Signed-off-by: Lukas Wagner > Tested-by: Folke Gleumes > --- > proxmox-notify/Cargo.toml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/proxmox-notify/Cargo.toml b/proxmox-notify/Cargo.toml > index 52a466e..185b50a 100644 > --- a/proxmox-notify/Cargo.toml > +++ b/proxmox-notify/Cargo.toml > @@ -17,13 +17,13 @@ log.workspace = true > mail-parser = { workspace = true, optional = true } > openssl.workspace = true > regex.workspace = true > -serde = { workspace = true, features = ["derive"]} > +serde = { workspace = true, features = ["derive"] } Nit: unrelated whitespace changes should be their own patch > serde_json.workspace = true > > proxmox-http = { workspace = true, features = ["client-sync"], optional = true } > proxmox-http-error.workspace = true > proxmox-human-byte.workspace = true > -proxmox-schema = { workspace = true, features = ["api-macro", "api-types"]} > +proxmox-schema = { workspace = true, features = ["api-macro", "api-types"] } > proxmox-section-config = { workspace = true } > proxmox-serde.workspace = true > proxmox-sys = { workspace = true, optional = true } > @@ -31,7 +31,7 @@ proxmox-time.workspace = true > > [features] > default = ["sendmail", "gotify", "smtp"] > -mail-forwarder = ["dep:mail-parser"] > +mail-forwarder = ["dep:mail-parser", "dep:proxmox-sys"] > sendmail = ["dep:proxmox-sys"] > gotify = ["dep:proxmox-http"] > pve-context = ["dep:proxmox-sys"] _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel