From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id DFFDA1FF09C
	for <inbox@lore.proxmox.com>; Mon, 05 Oct 2026 16:37:36 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 1E2CB216D5;
	Mon, 05 Oct 2026 16:37:25 +0200 (CEST)
Message-ID: <f94b22a0-bec9-4047-a606-6a980cb002d9@proxmox.com>
Date: Mon, 5 Oct 2026 16:37:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 qemu-server 07/16] config: add the efi-firmware option
To: Christian Ludwig <christian_ludwig@genua.de>, pve-devel@lists.proxmox.com
References: <cover.1790337423.git@genua.de>
 <819dba534c9f906bad8d34de900e7ca1028eca8b.1790337726.git@genua.de>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: 
 <819dba534c9f906bad8d34de900e7ca1028eca8b.1790337726.git@genua.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1791211028273
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.470 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: RTIKRLSW4MVCGVSY2MDNEN65LSRLWAHG
X-Message-ID-Hash: RTIKRLSW4MVCGVSY2MDNEN65LSRLWAHG
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 28.09.26 um 7:49 AM schrieb Christian Ludwig:
> @@ -6123,7 +6137,7 @@ sub get_current_vm_volumes {

The comment above this function needs to be updated.

>  
>      PVE::QemuConfig->foreach_volume_full(
>          $conf,
> -        { extra_keys => ['vmstate'] },
> +        { extra_keys => ['vmstate', 'efi-firmware'] },
>          sub {
>              my ($ds, $drive) = @_;
>  

Best Regards,
Fiona