From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5A9091FF165 for ; Thu, 31 Jul 2025 07:35:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1793031D20; Thu, 31 Jul 2025 07:37:24 +0200 (CEST) Message-ID: Date: Thu, 31 Jul 2025 07:36:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Daniel Kral References: <20250730175957.386674-1-d.kral@proxmox.com> <20250730175957.386674-14-d.kral@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250730175957.386674-14-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753940198207 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH ha-manager v5 13/23] api: introduce ha rules api endpoints X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 30.07.25 um 20:03 schrieb Daniel Kral: > + > +__PACKAGE__->register_method({ > + name => 'read_rule', > + method => 'GET', > + path => '{rule}', > + description => "Read HA rule.", > + permissions => { > + check => ['perm', '/', ['Sys.Audit']], > + }, > + parameters => { > + additionalProperties => 0, > + properties => { > + rule => get_standard_option( > + 'pve-ha-rule-id', > + { completion => \&PVE::HA::Tools::complete_rule }, > + ), > + }, > + }, > + returns => { > + type => 'object', > + properties => { > + rule => get_standard_option('pve-ha-rule-id'), > + type => { > + type => 'string', could be nice to have a enum or the like here to have more info in the API viewer and for our rust type code generation infra. > + }, > + }, > + }, > + code => sub { > +__PACKAGE__->register_method({ > + name => 'delete_rule', > + method => 'DELETE', > + path => '{rule}', > + description => "Delete HA rule.", > + permissions => { > + check => ['perm', '/', ['Sys.Console']], Pre-exiting, but yeah, we really need dedicated HA.{Audit,Modify,Use} permissions... _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel