From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id B4D551FF171
	for <inbox@lore.proxmox.com>; Fri, 29 Nov 2024 15:24:18 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id CF2ED1AD0E;
	Fri, 29 Nov 2024 15:24:21 +0100 (CET)
Message-ID: <f8dc6a35-2daf-4055-9b67-9e8f7c857cd1@proxmox.com>
Date: Fri, 29 Nov 2024 15:23:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Daniel Kral <d.kral@proxmox.com>
References: <20240916163839.236908-1-d.kral@proxmox.com>
 <20240916163839.236908-8-d.kral@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20240916163839.236908-8-d.kral@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.053 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [RFC qemu-server 7/9] api: migrate_vm: improve
 check if target storages support vm images
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Am 16.09.24 um 18:38 schrieb Daniel Kral:
> diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
> index a0abe44f..13c1c4e0 100644
> --- a/PVE/API2/Qemu.pm
> +++ b/PVE/API2/Qemu.pm
> @@ -220,18 +220,6 @@ my $check_storage_access_clone = sub {
>     return $sharedvm;
>  };
>  
> -my $check_storage_access_migrate = sub {
> -    my ($rpcenv, $authuser, $storecfg, $storage, $node) = @_;
> -
> -    PVE::Storage::storage_check_enabled($storecfg, $storage, $node);
> -
> -    $rpcenv->check($authuser, "/storage/$storage", ['Datastore.AllocateSpace']);
> -
> -    my $scfg = PVE::Storage::storage_config($storecfg, $storage);
> -    die "storage '$storage' does not support vm images\n"
> -	if !$scfg->{content}->{images};
> -};

I'd prefer to keep this helper and have it call the new ones.

> -
>  my $import_from_volid = sub {
>      my ($storecfg, $src_volid, $dest_info, $vollist) = @_;
>  


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel