From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 621086AF6A for ; Tue, 16 Mar 2021 09:04:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 588842A574 for ; Tue, 16 Mar 2021 09:04:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E53712A567 for ; Tue, 16 Mar 2021 09:04:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AB56D43AC2 for ; Tue, 16 Mar 2021 09:04:20 +0100 (CET) To: Thomas Lamprecht , Proxmox VE development discussion References: <20210311102650.6730-1-f.ebner@proxmox.com> <20210311102650.6730-4-f.ebner@proxmox.com> <915f2702-848e-eeac-f581-df94d048c5a9@proxmox.com> From: Fabian Ebner Message-ID: Date: Tue, 16 Mar 2021 09:04:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <915f2702-848e-eeac-f581-df94d048c5a9@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH v2 container 3/5] vmstatus: make template property optional X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 08:04:21 -0000 Am 15.03.21 um 14:01 schrieb Thomas Lamprecht: > On 11.03.21 11:26, Fabian Ebner wrote: >> to avoid printing 'template: ' with 'pct status --verbose' if it's false. >> >> Signed-off-by: Fabian Ebner >> --- >> >> Breaks pve-manager without the first patch! (e.g. guest's Start/Shutdown >> buttons won't be updated anymore) >> > > same here, looks OK, but we can only apply it to master once we branched off > the stable-6 release > Ok, I'll try to remember and send a ping/rebased version then. >> Changes from v1: >> * make property optional >> >> src/PVE/LXC.pm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm >> index bae236b..082cab8 100644 >> --- a/src/PVE/LXC.pm >> +++ b/src/PVE/LXC.pm >> @@ -235,7 +235,7 @@ sub vmstatus { >> $d->{diskread} = 0; >> $d->{diskwrite} = 0; >> >> - $d->{template} = PVE::LXC::Config->is_template($conf); >> + $d->{template} = 1 if PVE::LXC::Config->is_template($conf); >> $d->{lock} = $conf->{lock} if $conf->{lock}; >> } >> >> >