From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8E65EF31F for ; Thu, 20 Jul 2023 16:53:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 72515166B1 for ; Thu, 20 Jul 2023 16:53:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 20 Jul 2023 16:53:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7E8B340897 for ; Thu, 20 Jul 2023 16:53:13 +0200 (CEST) Message-ID: Date: Thu, 20 Jul 2023 16:53:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner References: <20230720094502.4146921-1-f.ebner@proxmox.com> <20230720094502.4146921-2-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230720094502.4146921-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.326 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH qemu-server 2/2] fix #4620: cfg2cmd: drive device: correctly handle IDE for q35 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2023 14:53:44 -0000 On 20/07/2023 11:45, Fiona Ebner wrote: > Only unit 0 for IDE is supported with machine type q35. Currently, > QEMU will fail startup with machine type q35 with an error like >> Can't create IDE unit 1, bus supports only 1 units > when ide1 or ide3 is configured. > > Make sure to keep backwards compat form migration by leaving ide0 and > ide2 fixed. Since starting with ide1 or ide3 never worked, they can be > moved to a controller with a higher ID without issue. > > Reported in the community forum: > https://forum.proxmox.com/threads/124615/post-543127 > https://forum.proxmox.com/threads/130815/ > > Signed-off-by: Fiona Ebner > --- > > For PVE 9, we could simplify the mapping to N -> controller=N,unit=0 > while version guarding with running QEMU machine version. Might be > slightly nicer, but it'd add an extra conditional, so probably not > worth it. > > PVE/QemuServer.pm | 11 +++++++++++ > test/cfg2cmd/q35-ide.conf.cmd | 4 ++-- > 2 files changed, 13 insertions(+), 2 deletions(-) > > applied, thanks!