From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5DE2B621F4 for ; Sat, 11 Jul 2020 17:26:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 47A83C15C for ; Sat, 11 Jul 2020 17:25:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 74813C14E for ; Sat, 11 Jul 2020 17:25:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3449042547 for ; Sat, 11 Jul 2020 17:25:46 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20200710164334.23819-1-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Sat, 11 Jul 2020 17:25:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.0 MIME-Version: 1.0 In-Reply-To: <20200710164334.23819-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [debian.pm] Subject: [pve-devel] applied: Re: [PATCH container] setup/debian: use cidr for buster and newer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jul 2020 15:26:17 -0000 On 10.07.20 18:43, Stoiko Ivanov wrote: > starting with version 0.8.35 of ifupdown (shipped currently with buster) > the configuration using a separate 'netmask' line instead of providing the > cidr in the 'address' line of a interface stanza of /etc/network/interfaces > is deprecated. > > This means that some software installed on newer debian versions, which > parses /etc/network/interfaces may not support the format currently written > by PVE::LXC::Setup::Debian::setup_network. > > This patch changes the content of the generated file to use the newer format > only for newer versions of debian (alpine, older ubuntu versions and devuan > also rely on the sub to generate the network config) > > caught by installing proxmox-backup-server on a debian buster container and > getting a parse-error in the network configuration tab in the GUI. > > tested by creating a ubuntu-14.04, debian-6, debian-8 and a debian-10 > container and checking the resulting /etc/network/interfaces. > > [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=912220 > > Signed-off-by: Stoiko Ivanov > --- > src/PVE/LXC/Setup/Debian.pm | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > applied, thanks!