From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 442237EC60 for ; Thu, 11 Nov 2021 14:04:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 399CCBBE4 for ; Thu, 11 Nov 2021 14:04:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2C083BBD3 for ; Thu, 11 Nov 2021 14:04:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9332842E35 for ; Thu, 11 Nov 2021 14:04:43 +0100 (CET) To: pve-devel@lists.proxmox.com, Oguz Bektas References: <20211111120558.1013617-1-o.bektas@proxmox.com> From: Fabian Ebner Message-ID: Date: Thu, 11 Nov 2021 14:04:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211111120558.1013617-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.195 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.999 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] cfg2cmd: also set smm=off for "none" type display X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 13:04:46 -0000 Am 11.11.21 um 13:05 schrieb Oguz Bektas: > issue reported in community forum [0] > > like "serial[n]" display we also need to set this option for > "none", otherwise we get a boot loop like in [1]. > > [0]: https://forum.proxmox.com/threads/debian-vms-wont-start-anymore.99508 > [1]: https://forum.proxmox.com/threads/pve-7-0-all-vms-with-cloud-init-seabios-fail-during-boot-process-bootloop-disk-not-found.97310/post-427129 > Tested for my reproducer and indeed, with display none and without this patch, there is a boot loop. Reviewed-by: Fabian Ebner Tested-by: Fabian Ebner > Signed-off-by: Oguz Bektas > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 9b76512..94576e1 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -3410,7 +3410,7 @@ my sub should_disable_smm { > my ($conf, $vga) = @_; > > return (!defined($conf->{bios}) || $conf->{bios} eq 'seabios') && > - $vga->{type} && $vga->{type} =~ m/^serial\d+$/; > + $vga->{type} && $vga->{type} =~ m/^(serial\d+|none)$/; > } > > sub config_to_command { >