From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 288421FF16F
for <inbox@lore.proxmox.com>; Thu, 13 Mar 2025 16:04:37 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id E3EF41C745;
Thu, 13 Mar 2025 16:04:26 +0100 (CET)
Message-ID: <f7a37ee8-2975-445b-9999-c3a231500cf7@proxmox.com>
Date: Thu, 13 Mar 2025 16:04:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
References: <20250204095733.55146-1-s.hanreich@proxmox.com>
<20250204095733.55146-3-s.hanreich@proxmox.com>
Content-Language: en-US
From: Hannes Laimer <h.laimer@proxmox.com>
In-Reply-To: <20250204095733.55146-3-s.hanreich@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.027 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH proxmox-firewall 3/3] tests: add Ping macro
to tests
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Tested these changes, I could reproduce the described problem, and
after applying the patches the macros only matches the correct ICMP
packets, not all.
so consider this:
Tested-by: Hannes Laimer <h.laimer@proxmox.com>
On 04.02.25 10:57, Stefan Hanreich wrote:
> Rules using the Ping macro were wrongly generated due to the ICMP
> macros using the wrong format for specifying ICMP type. The test cases
> did not include any macros utilizing the ICMP protocol. Add them to
> catch any errors related to ICMP parsing in the future.
>
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Depends on bumped proxmox-ve-config to work.
>
> proxmox-firewall/tests/input/host.fw | 1 +
> .../integration_tests__firewall.snap | 57 ++++++++++++++++++-
> 2 files changed, 57 insertions(+), 1 deletion(-)
>
> diff --git a/proxmox-firewall/tests/input/host.fw b/proxmox-firewall/tests/input/host.fw
> index a61b0bd..ddfcb1c 100644
> --- a/proxmox-firewall/tests/input/host.fw
> +++ b/proxmox-firewall/tests/input/host.fw
> @@ -20,6 +20,7 @@ nf_conntrack_helpers: amanda,ftp,irc,netbios-ns,pptp,sane,sip,snmp,tftp
> IN DNS(ACCEPT) -source dc/network1 -log nolog
> IN DHCPv6(ACCEPT) -log nolog
> IN DHCPfwd(ACCEPT) -log nolog
> +IN Ping(REJECT)
> IN REJECT -p udp --dport 443
> OUT REJECT -p udp --dport 443
>
> diff --git a/proxmox-firewall/tests/snapshots/integration_tests__firewall.snap b/proxmox-firewall/tests/snapshots/integration_tests__firewall.snap
> index 9194fc6..d25ece8 100644
> --- a/proxmox-firewall/tests/snapshots/integration_tests__firewall.snap
> +++ b/proxmox-firewall/tests/snapshots/integration_tests__firewall.snap
> @@ -1,7 +1,6 @@
> ---
> source: proxmox-firewall/tests/integration_tests.rs
> expression: "firewall.full_host_fw().expect(\"firewall can be generated\")"
> -snapshot_kind: text
> ---
> {
> "nftables": [
> @@ -3533,6 +3532,62 @@ snapshot_kind: text
> }
> }
> },
> + {
> + "add": {
> + "rule": {
> + "family": "inet",
> + "table": "proxmox-firewall",
> + "chain": "host-in",
> + "expr": [
> + {
> + "match": {
> + "op": "==",
> + "left": {
> + "payload": {
> + "protocol": "icmp",
> + "field": "type"
> + }
> + },
> + "right": "echo-request"
> + }
> + },
> + {
> + "jump": {
> + "target": "do-reject"
> + }
> + }
> + ]
> + }
> + }
> + },
> + {
> + "add": {
> + "rule": {
> + "family": "inet",
> + "table": "proxmox-firewall",
> + "chain": "host-in",
> + "expr": [
> + {
> + "match": {
> + "op": "==",
> + "left": {
> + "payload": {
> + "protocol": "icmpv6",
> + "field": "type"
> + }
> + },
> + "right": "echo-request"
> + }
> + },
> + {
> + "jump": {
> + "target": "do-reject"
> + }
> + }
> + ]
> + }
> + }
> + },
> {
> "add": {
> "rule": {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel