From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 20D7F8D8D9 for ; Wed, 9 Nov 2022 09:00:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06087194A2 for ; Wed, 9 Nov 2022 09:00:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Nov 2022 09:00:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CCA524316E for ; Wed, 9 Nov 2022 09:00:39 +0100 (CET) Message-ID: Date: Wed, 9 Nov 2022 09:00:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20220920125041.3636561-1-d.csapak@proxmox.com> <20220920125041.3636561-11-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220920125041.3636561-11-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, pci.pm] Subject: [pve-devel] applied: [PATCH qemu-server v3 01/13] cleanup pci devices in more situations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2022 08:00:41 -0000 Am 20/09/2022 um 14:50 schrieb Dominik Csapak: > if the preparing of pci devices or the start of the vm fails, we need > to cleanup the pci devices (reservations *and* mdevs), or else > it might happen that there are leftovers which must be manually removed. > > to include also mdevs now, refactor the cleanup code from 'vm_stop_cleanup' > into it's own function, and call that instead of only 'remove_pci_reservation' > > also simplifies the code, such that it now removes all pci ids reserved > for that vmid, since we cannot have multiple vms with the same vmid > anyway > > Signed-off-by: Dominik Csapak > --- > PVE/QemuServer.pm | 34 ++++++++++++++++++---------------- > PVE/QemuServer/PCI.pm | 12 +++++++----- > 2 files changed, 25 insertions(+), 21 deletions(-) > > I find it almost a bit odd though that we bothered to use a set of $dropped_ids in the first place anyhow, applied thanks!