From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5885476993; Fri, 23 Apr 2021 14:36:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4D1E429167; Fri, 23 Apr 2021 14:36:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DB9C529159; Fri, 23 Apr 2021 14:36:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A66EE458B9; Fri, 23 Apr 2021 14:36:33 +0200 (CEST) Message-ID: Date: Fri, 23 Apr 2021 14:36:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner , pbs-devel@lists.proxmox.com References: <20210409084436.2454-1-f.ebner@proxmox.com> <20210409084436.2454-7-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210409084436.2454-7-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.008 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH/RFC v2 common 6/7] allow workers to count warnings and finish tasks in a WARNINGS state X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Apr 2021 12:36:34 -0000 On 09.04.21 10:44, Fabian Ebner wrote: > as is already supported by the UI (and PBS). > > A nice bonus is that warn() can be used by both workers and non-workers. For > workers, the output is redirected/duplicated as set up by {fork,tee}_worker(), > and non-erroring workers that issued a warning will end in a WARNINGS state. > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * use chomp in warn(), so it can also be called with newline-terminated > strings > > src/PVE/RESTEnvironment.pm | 22 ++++++++++++++++++++-- > src/PVE/Tools.pm | 2 ++ > 2 files changed, 22 insertions(+), 2 deletions(-) > > applied, thanks!