From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8BEE3627CE for ; Fri, 21 Aug 2020 14:13:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6D284D2A6 for ; Fri, 21 Aug 2020 14:13:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 49D48D28C for ; Fri, 21 Aug 2020 14:13:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0B2EC44788 for ; Fri, 21 Aug 2020 14:13:28 +0200 (CEST) To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20200806111349.67063-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Fri, 21 Aug 2020 14:13:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <20200806111349.67063-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.083 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] applied: [RFC qemu-server] fix #2862: properly backup (all) VM templates X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2020 12:13:59 -0000 On 06.08.20 13:13, Fabian Gr=C3=BCnbichler wrote: > until we maybe have a 'pbs-backup' that links Qemu and PBS like > 'pbs-restore', we need to do a regular backup for the template case to > support all storage types and image formats. >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > requires patched pve-qemu to drop read-only check >=20 > alternatively, we could also start writing a pbs-backup (or a > general pbs-qemu ?) soon, and just disable PBS template backups in > the meantime. >=20 > PVE/QemuServer.pm | 6 +++++- > PVE/VZDump/QemuServer.pm | 22 +++++++--------------- > 2 files changed, 12 insertions(+), 16 deletions(-) >=20 > While not 100% happy with this, it works OK from what I can see. And we h= ighly probably won't write a pbs-backup wrapper just for this use-case. applied, thanks!