From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0796C1FF380 for ; Fri, 19 Apr 2024 12:10:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A3BBB5A8C; Fri, 19 Apr 2024 12:10:00 +0200 (CEST) Message-ID: Date: Fri, 19 Apr 2024 12:09:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Lukas Wagner References: <20240409132555.364926-1-l.wagner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240409132555.364926-1-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH many 00/19] notifications: move template strings to template files; PBS preparations X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Lamprecht Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 09.04.24 um 15:25 schrieb Lukas Wagner: > The notification system uses handlebar templates to render the subject > and the body of notifications. Previously, the template strings were > defined inline at the call site. This patch series extracts the templates > into template files and installs them at > /usr/share/proxmox-ve/templates/default > > where they stored as -{body,subject}.{txt,html}.hbs > > The 'default' part in the path is a preparation for translated > notifications and/or overridable notification templates. > Future work could provide notifications translated to e.g. German > in `templates/de` or similar. This will be a first for having > translated strings on the backend-side, so there is need for further > research. > > The patches for `proxmox` also include some preparatory patches for > the upcoming integration of the notification system into PBS. They > are not needed for PVE, but I included them here since Folke and I > tested the PVE changes with them applied. IMO they should just be > applied with the same version bump. > The list of optional, preparatory patches is: > notify: give each notification a unique ID > notify: api: add get_targets > notify: derive `api` for Deleteable*Property > notify: derive Deserialize/Serialize for Notification struct > notify: pbs context: include nodename in default sendmail author > notify: renderer: add relative-percentage helper from PBS > > Folke kindly did some off-list testing before this was posted, hence > his T-bs were included. > > Bumps/dependencies: > - proxmox_notify > - libproxmox-rs-perl/libpve-rs-perl (needs bumped proxmox_notify) > - libpve-notify-perl (needs bumped libproxmox-rs-perl/libpve-rs-perl) > - pve-ha-manager (needs bumped libpve-notify-perl) > - pve-manager (needs bumped libpve-notify-perl) > - proxmox-mail-forward (optional. should not be affected by any changes, but I think > it should be also be bumped for any larger proxmox_notify changes to avoid any > weird hidden regressions due to mismatches of proxmox_notify > Versioned breaks required: - new pve-cluster will break old pve-manager and old pve-ha-manager - new libproxmox-rs-perl/libpve-rs-perl will break old pve-cluster Still not too sure about putting the templates in /usr/share/proxmox-ve/, but maybe @Thomas or @Fabian can chime in on that. While I'm rather unfamiliar with the code and not much into Rust, everything looked good to me (just a few nits). So, with a grain of salt: Reviewed-by: Fiona Ebner _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel