From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB4E3A04BB for ; Tue, 13 Jun 2023 09:06:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9C6712A7DF for ; Tue, 13 Jun 2023 09:06:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 13 Jun 2023 09:06:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ECEE9447CD for ; Tue, 13 Jun 2023 09:06:05 +0200 (CEST) Message-ID: Date: Tue, 13 Jun 2023 09:05:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: Thomas Lamprecht , Proxmox VE development discussion , Christoph Heiss References: <20230509084654.666207-1-c.heiss@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.096 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jun 2023 07:06:06 -0000 Am 12.06.23 um 16:54 schrieb Thomas Lamprecht: > Am 12/06/2023 um 13:22 schrieb Fiona Ebner: >> Instead of getting rid of the "print once per line" handling, can't we >> rather adapt the invocation for backup to bubble up the other log lines too? > > would it make sense to differ between stderr/stdour and do log_warn and print, > respectively? > Could also be done, but from a quick look in the code, QEMU also prints its info_report() to stderr. Could lead to a bit of over-reporting as warnings in our task logs, but might be fine for most cases; there's not too many info_report instances. >> >> Always prefixing the messages with "QEMU: " seems fine to me (even >> things like the "bridge 'vmbr1' does not exist" message technically come >> from the pve-bridge script, it's still part of the QEMU invocation ;)). > > not sure if we really need a prefix at all here.. Well, the migration code currently expects it and it helps to recognize where the message comes from in complex logs like migration (and after this bug is fixed, backup).