From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2902C67B02 for ; Wed, 13 Jan 2021 12:27:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E08D10F14 for ; Wed, 13 Jan 2021 12:26:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6423210F07 for ; Wed, 13 Jan 2021 12:26:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28EC945694 for ; Wed, 13 Jan 2021 12:26:29 +0100 (CET) From: Mira Limbeck To: pve-devel@lists.proxmox.com References: <20210113090132.3889308-1-aderumier@odiso.com> Message-ID: Date: Wed, 13 Jan 2021 12:26:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210113090132.3889308-1-aderumier@odiso.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.445 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cloudinit.pm, readthedocs.io] Subject: Re: [pve-devel] [PATCH qemu-server] cloud-init: don't regenerate ssh hosts key on config change when vm is running X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 11:27:00 -0000 We could add vendor data and put the ssh keys there: https://cloudinit.readthedocs.io/en/latest/topics/vendordata.html On 1/13/21 10:01 AM, Alexandre Derumier wrote: > Currently, we always regenerate sshkeys on any config change. > > It should be done only before the first vm start, but currently can't known that. > > So, this patch only do it when vm is running. > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuServer/Cloudinit.pm | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/PVE/QemuServer/Cloudinit.pm b/PVE/QemuServer/Cloudinit.pm > index 52a4203..dd643c1 100644 > --- a/PVE/QemuServer/Cloudinit.pm > +++ b/PVE/QemuServer/Cloudinit.pm > @@ -135,6 +135,8 @@ sub cloudinit_userdata { > $content .= " - $k\n"; > } > } > + $content .= "ssh_deletekeys: false\n" if PVE::QemuServer::check_running($vmid); > + > $content .= "chpasswd:\n"; > $content .= " expire: False\n"; >