From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ABAF9B545 for ; Fri, 30 Jun 2023 13:55:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8CDC42347B for ; Fri, 30 Jun 2023 13:55:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 30 Jun 2023 13:55:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B386B42A09 for ; Fri, 30 Jun 2023 13:55:30 +0200 (CEST) Message-ID: Date: Fri, 30 Jun 2023 13:55:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US From: Fiona Ebner To: pve-devel@lists.proxmox.com Reply-To: Proxmox VE development discussion References: <20230630114923.65506-1-f.ebner@proxmox.com> <20230630114923.65506-2-f.ebner@proxmox.com> In-Reply-To: <20230630114923.65506-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.093 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH v2 cluster 2/4] pvecm: updatecerts: allow specifying time to wait for quorum via CLI argument X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2023 11:55:32 -0000 Am 30.06.23 um 13:49 schrieb Fiona Ebner: > Useful for the updatecerts call triggered via the ExecStartPre hook > for pveproxy.service. > > When starting a node that's part of a cluster, there is a time window > between the start of pve-cluster.service and when quorum is reached > (from the node's perspective). pveproxy.service is ordered after > pve-cluster.service, but that does not prevent the ExecStartPre hook > from being executed before the node is part of the quorate partition. > > The pvecm updatecerts command won't do much without quorum. Generating > local (non-pmxcfs) files is still done before waiting on quorum. > > In particular, it might happen that the base directories for observed > files will not get created during/after the upgrade from Proxmox VE 7 > to 8 (reported in the community forum [0] and reproduced right away in > a virtual test cluster). > > Waiting on quorum should highly increase the chances for successful > execution of the ExecStartPre hook. > > [0]: https://forum.proxmox.com/threads/129644/ > > Suggested-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner Sorry, noticed that I forgot to update the commit title here, will send a v3.