From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0522F7B1F5 for ; Tue, 11 May 2021 17:32:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E70FE23FFB for ; Tue, 11 May 2021 17:31:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D163323FEA for ; Tue, 11 May 2021 17:31:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AC69542E6E for ; Tue, 11 May 2021 17:31:52 +0200 (CEST) Message-ID: Date: Tue, 11 May 2021 17:31:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20210511110400.241153-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210511110400.241153-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [report.pm] Subject: [pve-devel] applied: [PATCH manager] pvereport: get pressure stall information X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 15:32:24 -0000 On 11.05.21 13:04, Oguz Bektas wrote: > PSI can be queried in /proc/pressure/{cpu,io,memory} for the > corresponding resources. this helps us track down disruptions caused > by resource overcommitment. > > Signed-off-by: Oguz Bektas > --- > PVE/Report.pm | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks! But the inserted order felt a bit weird to me, I found it fitting better below the `top` command a few commands above, but looking at the whole report module I found that it was due for some refactoring anyway, so as follow-up I: * got rid of all those ugly side-effects we relied on * made the definition hash the single source of info, dropping the extra order array, which was always a bit weird * split out the top and PSI into a new "system-load" section * adding some stderr output about what's going on in dir2text if something is off with my followups just shout.