From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01C1872213 for ; Tue, 15 Jun 2021 09:58:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E56272B0F0 for ; Tue, 15 Jun 2021 09:58:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 52CDC2B078 for ; Tue, 15 Jun 2021 09:58:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 29FC3439DB for ; Tue, 15 Jun 2021 09:58:02 +0200 (CEST) To: Lorenz Stechauner , Proxmox VE development discussion References: <20210614090557.33455-1-l.stechauner@proxmox.com> <20210614090557.33455-2-l.stechauner@proxmox.com> From: Lorenz Stechauner Message-ID: Date: Tue, 15 Jun 2021 09:58:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210614090557.33455-2-l.stechauner@proxmox.com> Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 1.291 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% HTML_MESSAGE 0.001 HTML included in message KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.489 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm] Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [PATCH v7 common 1/1] tools: add download_file_from_url X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jun 2021 07:58:11 -0000 adds a common function to download arbitrary files from urls. security notice: this function does not perform any permission checking. the calling function and/or api endpoint has to make sure, that only authorized users may use this function. caution: This function is able to download files from internal networks (which would not be visible/accessible from outside). On 14.06.21 11:05, Lorenz Stechauner wrote: > code is based on > manager:PVE/API2/Nodes.pm:aplinfo > > Signed-off-by: Lorenz Stechauner > --- > src/PVE/Tools.pm | 124 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 124 insertions(+) > > diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm > index 16ae3d2..7b82e00 100644 > --- a/src/PVE/Tools.pm > +++ b/src/PVE/Tools.pm > @@ -1829,4 +1829,128 @@ sub safe_compare { > return $cmp->($left, $right); > } > > + > +# opts > +# -> hash_required > +# if 1, at least one checksum has to be specified otherwise an error will be thrown > +# -> http_proxy > +# -> https_proxy > +# -> verify_certificates > +# -> sha(1|224|256|384|512)sum > +# -> md5sum > +sub download_file_from_url { > + my ($dest, $url, $opts) = @_; > + > + my $tmpdest = "$dest.tmp.$$"; > + > + my $algorithm; > + my $expected; > + > + for ('sha512', 'sha384', 'sha256', 'sha224', 'sha1', 'md5') { > + if (defined($opts->{"${_}sum"})) { > + $algorithm = $_; > + $expected = $opts->{"${_}sum"}; > + last; > + } > + } > + > + die "checksum required but not specified\n" if ($opts->{hash_required} && !$algorithm); > + > + my $worker = sub { > + my $upid = shift; > + > + print "downloading $url to $dest\n"; > + > + eval { > + if (-f $dest && $algorithm) { > + print "calculating checksum of existing file...\n"; > + my $correct = check_file_hash($algorithm, $expected, $dest); > + > + if ($correct) { > + print "file already exists, no need to download\n"; > + return; > + } else { > + print "mismatch, downloading\n"; > + } > + } > + > + my @cmd = ('/usr/bin/wget', '--progress=dot:mega', '-O', $tmpdest, $url); > + > + local %ENV; > + if ($opts->{http_proxy}) { > + $ENV{http_proxy} = $opts->{http_proxy}; > + } > + if ($opts->{https_proxy}) { > + $ENV{https_proxy} = $opts->{https_proxy}; > + } > + > + my $verify = $opts->{verify_certificates} // 1; > + if (!$verify) { > + push @cmd, '--no-check-certificate'; > + } > + > + if (run_command([[@cmd]]) != 0) { > + die "download failed: $!\n"; > + } > + > + if ($algorithm) { > + print "calculating checksum...\n"; > + > + my $correct = check_file_hash($algorithm, $expected, $tmpdest); > + > + if ($correct) { > + print "checksum verified\n"; > + } else { > + die "checksum mismatch\n"; > + } > + } else { > + print "no checksum for verification specified\n"; > + } > + > + if (!rename($tmpdest, $dest)) { > + die "unable to save file: $!\n"; > + } > + }; > + my $err = $@; > + > + unlink $tmpdest; > + > + if ($err) { > + print "\n"; > + die $err; > + } > + > + print "download finished\n"; > + }; > + > + my $rpcenv = PVE::RPCEnvironment::get(); > + my $user = $rpcenv->get_user(); > + > + (my $filename = $dest) =~ s!.*/([^/]*)$!$1!; > + > + return $rpcenv->fork_worker('download', $filename, $user, $worker); > +} > + > +sub check_file_hash { > + my ($algorithm, $expected, $filename) = @_; > + > + my $algorithm_map = { > + 'md5' => sub { Digest::MD5->new }, > + 'sha1' => sub { Digest::SHA->new(1) }, > + 'sha224' => sub { Digest::SHA->new(224) }, > + 'sha256' => sub { Digest::SHA->new(256) }, > + 'sha384' => sub { Digest::SHA->new(384) }, > + 'sha512' => sub { Digest::SHA->new(512) }, > + }; > + > + my $digester = $algorithm_map->{$algorithm}->() or die "unknown algorithm '$algorithm'\n"; > + > + open(my $fh, '<', $filename) or die "unable to open '$filename': $!\n"; > + binmode($fh); > + > + my $digest = $digester->addfile($fh)->hexdigest; > + > + return lc($digest) eq lc($expected); > +} > + > 1;