From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 34D221FF187 for ; Mon, 14 Jul 2025 12:48:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68ABE1416B; Mon, 14 Jul 2025 12:48:57 +0200 (CEST) Message-ID: Date: Mon, 14 Jul 2025 12:48:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Aaron Lauterer References: <20250702095202.2570401-1-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250702095202.2570401-1-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH manager v2] ui: node: use plug icon for node shutdown X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" I don't think we'll prevent all users from mis-clicking the button with this change, but having a different Icon can probably avoid *some* confusion. I don't really like that this icon would imply we 'pull the plug', but there is sadly not really a better icon that is different from the shutdown one. I'm a bit unsure myself, but *if* we want to have a different icon here than for the guest shutdown, consider this patch: Reviewed-by: Dominik Csapak On 7/2/25 11:52, Aaron Lauterer wrote: > this makes it optically different to the guest shutdown and hopefully > helps to avoid confusion and accidential node shutdowns. > > Signed-off-by: Aaron Lauterer > --- > > Notes: > changes since: > v1: > * rebased with updated indentations > > This came up in the forum and I do like the idea and the change is small > enough to just quickly do it > https://forum.proxmox.com/threads/disable-server-shutdown-restart-from-the-web-interface.12602/page-2#post-769235 > > www/manager6/node/Config.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js > index 4cd1671c..8946a616 100644 > --- a/www/manager6/node/Config.js > +++ b/www/manager6/node/Config.js > @@ -117,7 +117,7 @@ Ext.define('PVE.node.Config', { > handler: function () { > node_command('shutdown'); > }, > - iconCls: 'fa fa-power-off', > + iconCls: 'fa fa-plug', > }); > > var shellBtn = Ext.create('PVE.button.ConsoleButton', { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel