From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E87DE3F3 for ; Tue, 18 Jul 2023 14:35:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DE16A1AB5A for ; Tue, 18 Jul 2023 14:34:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 18 Jul 2023 14:34:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 296AD42BCD; Tue, 18 Jul 2023 14:34:55 +0200 (CEST) Message-ID: Date: Tue, 18 Jul 2023 14:34:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Lukas Wagner References: <20230717150051.710464-1-l.wagner@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20230717150051.710464-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v3 many 00/66] fix #4156: introduce new notification system X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2023 12:35:26 -0000 gave the series a quick spin, review of the gui patches comes later ;) a few high level comments from a user perspective: * the node fencing/replication edit windows always shows the warning that it shouldn't be disabled, that should imo only be there if i select 'never' ? (conversely, the package update window never shows the warning...) * when we have this, we could remove the pacakge notify line from the datacenter options, no? * imho having "Notification Targets" directly below "Notifications" is a bit redundant (and wasting space), but it's just a minor thing * the filter 'mode' is also not exposed on the gui (intentionally?) * also the mode is not quite clear since only one filter can be active per target? (or is it meant when there are multiple filter by means of notification groups?) * what is a filter without a minimum severity? what does it do? (does it make sense to allow such filters in the first place?) * the backup edit window is rather tall at this point, and if we assume a minimum screen size of 1280x720 there is not quite enough space when you subtract the (typical) os bar and browser window decoration, maybe a 'notification' tab would be better (we already have some tabs there anyway) * i found one bug, but not quite sure yet where it comes from exactly, putting in emojis into a field (e.g. a comment or author) it's accepted, but editing a different entry fails with: --->8--- could not serialize configuration: writing 'notifications.cfg' failed: detected unexpected control character in section 'testgroup' key 'comment' (500) ---8<--- not sure where the utf-8 info gets lost. (or we could limit all fields to ascii?) such a notification target still works AFAICT (but if set as e.g. the author it's probably the wrong value) (i used 😀 as a test) otherwise works AFAICT