From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3167B1FF179 for ; Wed, 21 Jan 2026 09:09:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0173C1F13A; Wed, 21 Jan 2026 09:09:26 +0100 (CET) Message-ID: Date: Wed, 21 Jan 2026 09:08:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Thomas Lamprecht , Christoph Heiss References: <20260120131319.949986-1-c.heiss@proxmox.com> <20260120131319.949986-5-c.heiss@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768982876652 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [sysfstools.pm] Subject: Re: [pve-devel] [PATCH common 4/4] sysfs: use new PVE::RS::VFIO::Nvidia module to retrieve vGPU info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 1/20/26 4:00 PM, Thomas Lamprecht wrote: > Am 20.01.26 um 14:12 schrieb Christoph Heiss: >> pci_dev_physfn_id() is used to obtain the parent device of a virtual >> function, i.e. the physical function. >> >> Needed for retrieving information about Nvidia vGPU devices via >> proxmox-ve-vfio, as libnvidia-ml functions only work with physical >> functions. >> >> Signed-off-by: Christoph Heiss >> --- >> src/PVE/SysFSTools.pm | 45 ++++++++++++++++++++++++++++++------------- >> 1 file changed, 32 insertions(+), 13 deletions(-) >> >> diff --git a/src/PVE/SysFSTools.pm b/src/PVE/SysFSTools.pm >> index a00fbcb..89e57b9 100644 >> --- a/src/PVE/SysFSTools.pm >> +++ b/src/PVE/SysFSTools.pm >> @@ -4,8 +4,10 @@ use strict; >> use warnings; >> >> use IO::File; >> +use File::Basename; >> >> use PVE::Tools qw(file_read_firstline dir_glob_foreach); >> +use PVE::RS::VFIO::Nvidia; > > we do not depend on libpve-rs-perl in libpve-common-perl, and if easily possible > I'd strongly favor keeping it that way, bootstrapping and handling bigger package > bumps with newer versioned dependencies or break/depends bumps is already quite > a bit of work as is, such stuff does not make it easier, especially if adding > a new dependencies is not recorded in d/control's packaging definition. > > Can this move to some non-leaf package instead? Where are the users of this, only > qemu-server or other too (pve-manager?)? > > hmm.. as far as i can see it, we need to use that module in sysfstools where we get info about mdevs. This is used in qemu-server and (currently) pve-manager If we don't want to have that dep here, we have IMO the following possiblities: * split the relevant part out (e.g. into qemu-server, still reachable from pve-manager). * move the whole of sysfstools somewhere else this is needed in guest-common, pve-manager and qemu-server, so imho guest-common would be the next best place? though we could also create a seperate package for that too. Note that pve-storage still includes PVE::SysFSTools, but does not actually need it anymore, so we should remove it there anyway Advantage of the second method (though more work) would be to make pve-common smaller. We could also think about producing more than one debian package from pve-common, similar to how we do it with the 'proxmox' rust crate, not sure how practical that is though. In summary I think simply moving the mdev/vgpu stuff to qemu-server makes the most sense for now. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel