From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B5ADE7033A for ; Fri, 2 Apr 2021 11:22:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A86D2D122 for ; Fri, 2 Apr 2021 11:22:42 +0200 (CEST) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2D1A3D119 for ; Fri, 2 Apr 2021 11:22:42 +0200 (CEST) Received: by mail-wm1-x32b.google.com with SMTP id t5-20020a1c77050000b029010e62cea9deso2107108wmi.0 for ; Fri, 02 Apr 2021 02:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=YaW98nHQ+8qT5oib/AhhZbFPHXJwvhYQItLCNTnmcDc=; b=ChU25aqc7Z9ZENhpN8Jyod0Sx8SUNSY0+QLvXDPVxuo7Owr/rw9kBIFd3+VIA3+55+ s1hK6+BDyG4nnyNA4S4MuX6m4o6vmhA3J5mG2E1hE5E5RSqQzh3XXlL/hl/hpNCH3TO2 SdexRCb8qEEynwCSwG0xio8FH3/xqO5YKNynWMN2dtFosLVK3E1x482NTp4kamM017ch TnkZ61riSGugcy00IA2igawRlNGpMeGrvkeZj2U7WWB3BR1UGv5EibEv8FeOI52dsBpO OIw6FbSBZOmTD6ss91d7AQxndkQ4NOSTXXYKz43Yj99y11uuvRQuQ6FIEj50aX2ohFdG xPYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=YaW98nHQ+8qT5oib/AhhZbFPHXJwvhYQItLCNTnmcDc=; b=umlf8FYGspPOdOeoeq+Eg9qMoJf9qk74HrLyjty0m3VBj6JDQpVjRGvdl15wPF4kG0 Dv4+AEH8g9lSbQ4vl+z9Hd0k3+BDy1bI2rWU+1rJR57gJ9cpHoYZaUxJd8cGkPpwBuB6 BA9xdeILAR9BIF3+Qvcr7Nx3ZJzUHJxfo2V8duaT43jcWIm38UVhjNYLj8QCwdqLlrl1 lUVnWK6SqzF1UJUNH7C4Eg8jtGokU03GMPt1ip4uEVwV8PkcuvhsDGMkAed+yPmN9Pja +5Sye+WFdJa/sfWwCoUbJCUCTiJ8wWAAuKREWDV9wFn6KEdYR82XMceaNZANV8fLvd53 44aA== X-Gm-Message-State: AOAM532u6tSi+XpMXA4wrMAohBubZjfpev9TVc7+OSdX/2bPyWDUedeF dPti+be9uwkpUZCfEi0crJgiFg== X-Google-Smtp-Source: ABdhPJxqJajvZB5R4XC8a6d0Qv3Zo8Bgc/ScM0eoxCN6yyuSrExvZ2z+G3repWgel2GyCeDPTfI/pg== X-Received: by 2002:a05:600c:4fc2:: with SMTP id o2mr11558832wmq.25.1617355355814; Fri, 02 Apr 2021 02:22:35 -0700 (PDT) Received: from ?IPv6:2a0a:1580:0:1::100c? (ovpn1.odiso.net. [2a0a:1580:2000::3f]) by smtp.gmail.com with ESMTPSA id s3sm11465412wmd.21.2021.04.02.02.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Apr 2021 02:22:35 -0700 (PDT) Message-ID: From: aderumier@odiso.com To: Thomas Lamprecht , Proxmox VE development discussion Date: Fri, 02 Apr 2021 11:22:34 +0200 In-Reply-To: <716d60aa36860a8ed739cd45af8c5bfd99bf973e.camel@odiso.com> References: <20210328151203.2063706-1-aderumier@odiso.com> <20210328151203.2063706-2-aderumier@odiso.com> <93b9f005-6922-5903-31a9-a72ea6fc7d49@proxmox.com> <716d60aa36860a8ed739cd45af8c5bfd99bf973e.camel@odiso.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.092 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 1/6] cloudinit: add cloudinit section for current generated config. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 09:22:42 -0000 Maybe, another way, instead writing [cloudnit:special] section, we could write this config section inside the drive image directly when we generate it (to avoid to reparse format generate config) so we could read the drive to display the diff in the gui (we already have an cloudinit dump api, don't seem to be slow) what do you think about this ? Le jeudi 01 avril 2021 à 12:22 +0200, aderumier@odiso.com a écrit : > Le jeudi 01 avril 2021 à 10:54 +0200, Thomas Lamprecht a écrit : > > > > actually, why isn't the pending section enough for this? > > > > If stuff can be hot plugged then we can do so and if only that > > changed we > > can just remove it from pending, as normally? > > Well, for example, if you change the vm name , how to you manage that > ? > do you want to keep it as pending  until we regenerate cloudinit > drive? > > or more complex, if you change the mac address of the vm. (so > unplug/replug the nic) > for the nic, you don't want to keep it as pending, as technically, is > really plugged. > > or if you change the storage of the cloudinit drive, currently they a > no way to known if we need to regenerate it. > > The main problem is that pending section, is more for pending qemu > change, > not pending cloudinit config drive regeneration. > > For me, both are differents. > > > Currently,it's working well when vm is offline, because we don't have > any pending, and we regenerate the disk at vm startup. > > > (I'm really looking to use cloudinit for online config changes, like > for containers) > > > > > > > > >