From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 42C9562100 for <pve-devel@lists.proxmox.com>; Mon, 21 Feb 2022 09:40:17 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 31B585C67 for <pve-devel@lists.proxmox.com>; Mon, 21 Feb 2022 09:39:47 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8E3B85C5C for <pve-devel@lists.proxmox.com>; Mon, 21 Feb 2022 09:39:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6055041C52 for <pve-devel@lists.proxmox.com>; Mon, 21 Feb 2022 09:39:46 +0100 (CET) Message-ID: <f3c0f818-d8df-0de0-6068-57e00b30c23c@proxmox.com> Date: Mon, 21 Feb 2022 09:39:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Fabian Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com, m.heiserer@proxmox.com References: <20220218104230.311652-1-m.heiserer@proxmox.com> <7c867147-33b0-427c-4c6f-09fa84562d7f@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <7c867147-33b0-427c-4c6f-09fa84562d7f@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] storage GUI: fix unintuitive sorting order X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 21 Feb 2022 08:40:17 -0000 On 21.02.22 09:32, Fabian Ebner wrote: > Am 18.02.22 um 11:42 schrieb Matthias Heiserer: >> The backups in the 'Backups' table in Storages are now initially >> sorted by column 'Name' ascending. >> >> Previously, they were first sorted by 'vmid' descending, then by date >> descending. This was unintuitive as 'vmid' doesn't exist as column >> in the GUI, and only 'Date' displayed a sorting arrow. >> >> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com> >> --- >> www/manager6/storage/BackupView.js | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> > Please note that the order was recently intentionally changed to be like > that, see commit 58f4e6ac387561a16ec370812083d60a12dc4cfe > > That said, you do have a point. One way to improve the situation might > be to add a vmid column, but we could also think about using a tree view > for backups instead. >> @Thomas: Would the latter be okay for you? A tree view like PBS has would be nice in general IMO for the storage backup content view, as with lots of VMs that's way easier to browse/work with than the flat list. IIRC we talked about that already in the past, in the context of the prune group button, but it wasn't to pressing then and went off the radar. Adding the vmid, at least as by-default hidden column, would be the easiest (quickest) change now though, but this is IMO not to pressing that we need to do any stop-gap measures.