From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 664AA60487 for ; Wed, 16 Feb 2022 08:34:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5BE8A386 for ; Wed, 16 Feb 2022 08:34:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 41196376 for ; Wed, 16 Feb 2022 08:34:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0D9FF46248 for ; Wed, 16 Feb 2022 08:34:14 +0100 (CET) Message-ID: Date: Wed, 16 Feb 2022 08:34:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20211029111624.142116-1-f.ebner@proxmox.com> From: Fabian Ebner In-Reply-To: <20211029111624.142116-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.135 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC v2 common 1/2] REST environment: add static log_warn function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Feb 2022 07:34:15 -0000 Ping for this series Am 29.10.21 um 13:16 schrieb Fabian Ebner: > which avoids the need for the caller to check whether the environment > was initialized or not. > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * The static function now calls the class method, rather than the > other way around. If the current environment is a derived class > providing its own implementation of warn(), the static function > will call that one. > > src/PVE/RESTEnvironment.pm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm > index 189a6cd..bf10040 100644 > --- a/src/PVE/RESTEnvironment.pm > +++ b/src/PVE/RESTEnvironment.pm > @@ -712,6 +712,17 @@ sub fork_worker { > return wantarray ? ($upid, $res) : $upid; > } > > +sub log_warn { > + my ($message) = @_; > + > + if ($rest_env) { > + $rest_env->warn($message); > + } else { > + chomp($message); > + print STDERR "WARN: $message\n"; > + } > +} > + > sub warn { > my ($self, $message) = @_; >