From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F3ADF7B9D9 for ; Tue, 12 Jul 2022 13:32:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA92A273AD for ; Tue, 12 Jul 2022 13:32:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 12 Jul 2022 13:32:12 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5822F41F6B for ; Tue, 12 Jul 2022 13:32:12 +0200 (CEST) Message-ID: Date: Tue, 12 Jul 2022 13:32:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220513134900.440420-1-m.heiserer@proxmox.com> <20220513134900.440420-2-m.heiserer@proxmox.com> From: Matthias Heiserer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.183 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 http-server 2/2] AnyEvent: Fix #3990 - make small files uploadable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 11:32:17 -0000 On 06.07.2022 18:09, Daniel Tschlatscher wrote: > All errors above return HTTP status 501 ("Not implemented") which I > think is rather confusing, even if they include a descriptive error > message. > I'd wager that it would be better to differentiate between malformed > multi-form data and internal server errors, and return 400 for incorrect > user inputs. This makes it much easier for anyone (that is not a > browser) to interface with this part of the API. > > I am not quite sure how much precedence fixing the errors above should > have, as even most API users will probably never encounter them. > However, I feel like that at the very least the basic error message > should be revised to no longer return 501 and to include a more > descriptive error message than just "upload failed". As we talked off list: The 501 error is what we currently return. I don't mind using more descriptive ones, but as it changes the API I'm not sure if this patch is the right place. Thanks for testing!