From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C6CC761FD3 for ; Tue, 29 Sep 2020 05:09:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B17E3AF47 for ; Tue, 29 Sep 2020 05:09:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 13F11AF37 for ; Tue, 29 Sep 2020 05:09:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D152A45803 for ; Tue, 29 Sep 2020 05:09:05 +0200 (CEST) To: Proxmox VE development discussion , Fabian Ebner References: <20200928094837.26162-1-f.ebner@proxmox.com> From: Thomas Lamprecht Message-ID: Date: Tue, 29 Sep 2020 05:09:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20200928094837.26162-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.170 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, zfspoolplugin.pm] Subject: [pve-devel] applied: [PATCH v2 storage] ZFS: mount subvols in activate_volume X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 03:09:08 -0000 On 28.09.20 11:48, Fabian Ebner wrote: > Makes it possible to clone and start a container whose > ZFS subvols are not yet mounted for some reason. If a > subvol cannot be mounted, there's a better error now: > zfs error: cannot mount '/myzpool/subvol-103-disk-0': directory is not empty > > Previously, cloning would quietly do an "empty" clone, > and startup would fail with: > mount_autodev: 1074 Permission denied - Failed to create "/dev" directory > lxc_setup: 3238 Failed to mount "/dev" > do_start: 1224 Failed to setup container "103" > __sync_wait: 41 An error occurred in another process (expected sequence number 5) > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * not a change in this patch, but important: > commit e8bb92bd2b1af95fd20db1b4aeb3dabc2811f571 moved volume activation > to vm_start, meaning that the mount operation introduced by this patch > does not happen (and fail) in the restricted apparmor context anymore > * adapt commit message to reflect current behavior (when the first version > was sent, starting failed quietly without producing an error) > * rebase against current master > > Previous discussion: > https://lists.proxmox.com/pipermail/pve-devel/2020-April/043088.html > > PVE/Storage/ZFSPoolPlugin.pm | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > applied, thanks!