From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 59CD299183 for ; Tue, 10 Oct 2023 13:34:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3A9AA32055 for ; Tue, 10 Oct 2023 13:33:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 10 Oct 2023 13:33:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1AE67449A4 for ; Tue, 10 Oct 2023 13:33:46 +0200 (CEST) Date: Tue, 10 Oct 2023 13:33:45 +0200 From: Christoph Heiss To: Filip Schauer Cc: Proxmox VE development discussion Message-ID: References: <20230804102646.34999-1-f.schauer@proxmox.com> <20230804102646.34999-2-f.schauer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804102646.34999-2-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2023 11:34:18 -0000 Needs to be done for the TUI installer as well. Easiest way here is to add `state` to each interface in Proxmox::Sys::RunEnv::query_netdevs(), then deserialize that in `setup::Interface`. Looking at it, adding the MAC address there too would be great, if you are already at it. On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote: > > Signed-off-by: Filip Schauer > --- > proxinstall | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proxinstall b/proxinstall > index d5b2565..9316578 100755 > --- a/proxinstall > +++ b/proxinstall > @@ -347,7 +347,7 @@ sub create_ipconf_view { > > my $get_device_desc = sub { > my $iface = shift; > - return "$iface->{name} - $iface->{mac} ($iface->{driver})"; > + return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}"; I think it would be better to only show the state if the interface is actually UP - thus drawing immediate attention to these list entries and not completely overloading that dropdown. Maybe even append it as "(UP)" instead of by dash (as it does not really identify the interface, but rather is a property of it). > }; > > my $run_env = Proxmox::Install::RunEnv::get(); > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >