From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5373191D29 for ; Sat, 11 Mar 2023 17:33:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 372C62B22E for ; Sat, 11 Mar 2023 17:33:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Sat, 11 Mar 2023 17:33:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6956E42905 for ; Sat, 11 Mar 2023 17:33:42 +0100 (CET) Message-ID: Date: Sat, 11 Mar 2023 17:33:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion , Dominik Csapak References: <20230310140808.2245916-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230310140808.2245916-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit 1/1] inputpanel: improve validitychange check for advanced fields X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2023 16:33:43 -0000 Am 10/03/2023 um 15:08 schrieb Dominik Csapak: > instead of only checking the validity of the advanced items when > the form validity changed as a whole, add a validitychange listener > to each field in the advanced section. > > This improves the behaviour such that everytime an advanced field gets > invalid the items are show, not only when the form was valid before. > > Signed-off-by: Dominik Csapak > --- > we need this for the next patch for manager to work correctly, > but i guess this can happen on other panels too, just harder to trigger > > src/window/Edit.js | 27 ++++++++++++--------------- > 1 file changed, 12 insertions(+), 15 deletions(-) > > applied, with Aaron's T-b, thanks!