From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F25957F6BA for ; Fri, 12 Nov 2021 17:03:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ECE321C97A for ; Fri, 12 Nov 2021 17:03:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 89FB61C96B for ; Fri, 12 Nov 2021 17:03:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6209043417 for ; Fri, 12 Nov 2021 17:03:43 +0100 (CET) Message-ID: Date: Fri, 12 Nov 2021 17:03:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20211112160104.506805-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211112160104.506805-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: ceph: add more compatibilty code for versions X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Nov 2021 16:03:44 -0000 On 12.11.21 17:01, Dominik Csapak wrote: > we now have to handle the version of 'old' nodes, as well as the > new nodes, which are missing the 'version' field in the metadata/osd call > > so set the 'versions' object to a default empty object for osds > and get the host version directly from the treenode > (the parent node of the osd node) > > also compare the host version in the dashboard by getting first the > new version field, and the old one as fallback. > > Signed-off-by: Dominik Csapak > --- > www/manager6/ceph/OSD.js | 5 +++-- > www/manager6/ceph/Services.js | 3 ++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > applied, thanks!