From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E52FC1FF187 for ; Mon, 11 Aug 2025 14:21:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CEA2F356D8; Mon, 11 Aug 2025 14:22:38 +0200 (CEST) Message-ID: Date: Mon, 11 Aug 2025 14:22:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Shan Shaji References: <20250804110634.64816-1-s.shaji@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250804110634.64816-1-s.shaji@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754914927411 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v4] fix: ui: remove blue background under bottom bar in iOS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 8/4/25 13:07, Shan Shaji wrote: > In iOS, there was a blue background color visible beneath the bottom > bar, which caused the app to not utilize the full screen height. > Additionally, the colors of the app bar and the status bar > differed when the user began scrolling. > > This issue was due to the container color used in the `ColoredSafeArea` > widget, which wrapped the `SafeArea` widget. To fix the issue, > remove the `ColoredSafeArea` and its usages, as all affected screens > already include an `AppBar` widget. Therefore, using a separate > `SafeArea` is not necessary. > > Additionaly since the `SafeArea` inside the resource tab and the > task log page is removed as a result the filter sheet was interferring > with the status bar in Android and notch in iOS. To fix the > issue, wrap the drawer content in `SafeArea`. > > Signed-off-by: Shan Shaji > --- > > note: Skips running the `dart format` command as there are formatting > changes in the changed files and will be hard to identify the changes > if the files are formatted. > > changes since v3: > * Rebase with master. > > changes since v2: > * Move dart format related commit message under "---" > * Fix in-consistency of filter sheet on task log widget and > resource tab. Both filter sheets are now rendered on top > of App bar. > > changes since v1: > * Rebase the changes with master. > > lib/pages/main_layout_slim.dart | 12 +++++++----- > lib/widgets/colored_safe_area.dart | 18 ------------------ > lib/widgets/pve_console_menu_widget.dart | 3 +-- > lib/widgets/pve_lxc_options_widget.dart | 5 +---- > lib/widgets/pve_lxc_overview.dart | 5 +---- > lib/widgets/pve_node_overview.dart | 5 +---- > lib/widgets/pve_qemu_options_widget.dart | 5 +---- > lib/widgets/pve_qemu_overview.dart | 6 ++---- > lib/widgets/pve_task_log_widget.dart | 10 ++++------ > 9 files changed, 18 insertions(+), 51 deletions(-) > delete mode 100644 lib/widgets/colored_safe_area.dart > > applied, thanks! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel