From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C05ED6B4B2 for ; Fri, 18 Mar 2022 15:51:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA10B1F69D for ; Fri, 18 Mar 2022 15:51:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 391981F692 for ; Fri, 18 Mar 2022 15:51:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0AA8346EF0 for ; Fri, 18 Mar 2022 15:51:36 +0100 (CET) Message-ID: Date: Fri, 18 Mar 2022 15:51:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-GB To: Proxmox VE development discussion , Matthias Heiserer References: <20220318135226.2360890-1-m.heiserer@proxmox.com> <20220318135226.2360890-3-m.heiserer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220318135226.2360890-3-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 2/5 v2] GUI: Utils: Helpers for backup type and icon X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 14:51:36 -0000 On 18/03/2022 14:52, Matthias Heiserer wrote: > Signed-off-by: Matthias Heiserer > --- > changes from v1: > add "backup" to name > return empty string instead of throwing patch order is wrong though, you cannot use a helper in patch 1/x and only introduce it in a later patch. This break bisect and causal order, both things I'm fond of :) order can be fixed on apply for this one, at least if there's nothing else that comes up, but please avoid that pattern for future series (or if this one gets a v3) > www/manager6/Utils.js | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index aafe359a..337ccfae 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -1803,6 +1803,26 @@ Ext.define('PVE.Utils', { > > return undefined; > }, > + > + get_backup_type_icon_cls: function(volid, format) { > + var cls = ''; nit: we use `let` for new code, but actually I'd just return directly, like you do in the other helper, the intermediate variable has no real benefit in this small, straight forward function. > + if (PVE.Utils.volume_is_qemu_backup(volid, format)) { > + cls = 'fa-desktop'; > + } else if (PVE.Utils.volume_is_lxc_backup(volid, format)) { > + cls = 'fa-cube'; > + } > + return cls; > + }, > + > + get_backup_type: function(volid, format) { > + if (PVE.Utils.volume_is_qemu_backup(volid, format)) { > + return 'qemu'; > + } else if (PVE.Utils.volume_is_lxc_backup(volid, format)) { > + return 'lxc'; > + } else { > + return ''; > + } > + }, > }, > > singleton: true,