From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 355E791F52 for ; Wed, 5 Apr 2023 09:44:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1641124188 for ; Wed, 5 Apr 2023 09:44:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 5 Apr 2023 09:44:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B9D6245B6F for ; Wed, 5 Apr 2023 09:44:03 +0200 (CEST) Message-ID: Date: Wed, 5 Apr 2023 09:43:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: pve-devel@lists.proxmox.com References: <20221116140435.93067-1-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20221116140435.93067-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.761 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.925 Looks like a legit reply (A) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES manager] backup permission improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2023 07:44:05 -0000 Am 16.11.22 um 15:04 schrieb Fiona Ebner: > Currently, suffenciently privileged users may edit a backup job, but > cannot run the very same job manually (via the vzdump API call). The > first patch addresses this by removing the root-only restriction from > retention and performance settings. Retention will require > Datastore.Allocate on the target storage, because it's essentially > removal of certain backups, while performance settings will require > Sys.Modify on / which is the permission required to edit backup jobs. > > The next three patches are for deletion of parameters when updating a > backup job. Allowing to only delete a setting (previously, update > would fail if no parameter was set) and adding a check for the delete > options. > > Patch 5/6 restricts backup editing by requiring that the user has > appropriate permissions on the job's storage (and eventual newly set > storage) as well as on the default 'local' storage when removing the > storage. Jobs with a dumpdir can only be edited by root. This is a > breaking API change, but requiring permission on the storage should > be sensible and allows for more flexible permission configurations. > > The last patch introduces a helper to have the "what's the storage" > logic in one place. > Ping for the rest of the series, should still apply. Just ran into the issue that 3/6 fixes with: pvesh set /cluster/backup/backup-4f2f3b87-0165 --delete script Maybe we want to wait with 5/6 until to the next major release though.