From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 90CA971274 for ; Fri, 17 Jun 2022 17:34:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87943184A7 for ; Fri, 17 Jun 2022 17:34:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 595031849A for ; Fri, 17 Jun 2022 17:34:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 23A1B4351D for ; Fri, 17 Jun 2022 17:34:43 +0200 (CEST) Message-ID: Date: Fri, 17 Jun 2022 17:34:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak References: <20220613132411.3736044-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220613132411.3736044-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm, jobs.pm, backup.pm, vzdump.pm, pvescheduler.pm] Subject: [pve-devel] applied-series: [PATCH manager/docs v3] handle missed jobs better X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2022 15:34:44 -0000 Am 13/06/2022 um 15:24 schrieb Dominik Csapak: > by adding a config option 'repeat-missed' for jobs that repeats the jobs > on pvescheduler start. new default is 0, which is reverse to current > behaviour (but the more expected one) > > also always skips "missed" jobs when changing from disabled to enabled, > since that is not expected > > changes from v2: > * indendation/whitespaces fixes > * line length/wording fixes > * renamed updated_job_schedule to update_last_runtime picking up R-b's (much thanks for doing that!) could be also seen as somewhat noteworthy change IMO, but I could find it out by actually checking the patches rather quickly, so def. no biggie (just mentioning it early now that we work more and more with patch series that got mainly reviewed by someone else than the one pushing it out). > > changes from v1: > * rename 'skip-missed' to 'repeat-missed' and reverse the default > * always update timestamp on disabled -> enabled > * put the checkbox in advanced items > > pve-manager: > > Dominik Csapak (3): > fix #4026: add 'repeat-missed' option for jobs > fix #4053: don't run vzdump jobs when they change from > disabled->enabled > ui: dc/Backup: add 'repeat-missed' checkbox > > PVE/API2/Backup.pm | 37 ++++++++++++++++++++++++++++++++----- > PVE/Jobs.pm | 8 +++++++- > PVE/Jobs/Plugin.pm | 7 +++++++ > PVE/Jobs/VZDump.pm | 1 + > PVE/Service/pvescheduler.pm | 6 +++++- > www/manager6/dc/Backup.js | 13 ++++++++++++- > 6 files changed, 64 insertions(+), 8 deletions(-) > > pve-docs: > > Dominik Csapak (1): > vzdump: add section about 'repeat-missed' > > vzdump.adoc | 6 ++++++ > 1 file changed, 6 insertions(+) > applied, thanks!