From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 34B051FF380 for ; Fri, 19 Apr 2024 10:14:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 712881566; Fri, 19 Apr 2024 10:14:25 +0200 (CEST) Message-ID: Date: Fri, 19 Apr 2024 10:14:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Lukas Wagner References: <20240409132555.364926-1-l.wagner@proxmox.com> <20240409132555.364926-2-l.wagner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240409132555.364926-2-l.wagner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox 01/19] notify: switch to file-based templating system X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 09.04.24 um 15:25 schrieb Lukas Wagner: > Instead of passing the template strings for subject and body when > constructing a notification, we pass only the name of a template. > When rendering the template, the name of the template is used to find > corresponding template files. For PVE, they are located at > /usr/share/proxmox-ve/templates/default. The `default` part is > the 'template namespace', which is a preparation for user-customizable > and/or translatable notifications. > Is the plan to create different namespaces there ourselves or tell users they can put their custom templates there? In the latter case, I'm not sure /usr/share is the best place, rather than some place under /etc/ Who adds the template files? I don't see a patch for proxmox-ve in this series. Does this series require some versioned breaks to some package? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel