From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EFF691FF0B3 for ; Wed, 14 Oct 2026 14:35:22 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id AD07C2145A; Wed, 14 Oct 2026 14:35:20 +0200 (CEST) Message-ID: Date: Wed, 14 Oct 2026 14:35:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner Subject: Re: [PATCH ha-manager v3 08/21] queue resource motion: support migration options To: Daniel Kral , pve-devel@lists.proxmox.com References: <20260918160841.128088-1-f.ebner@proxmox.com> <20260918160841.128088-9-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791981316586 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.427 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LH3HVN7GHV23OPV3AZJTNWH6TIZQ3KPF X-Message-ID-Hash: LH3HVN7GHV23OPV3AZJTNWH6TIZQ3KPF X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 13.10.26 um 2:22 PM schrieb Daniel Kral: > On Fri Sep 18, 2026 at 6:08 PM CEST, Fiona Ebner wrote: >> @@ -651,7 +651,7 @@ sub queue_resource_motion { >> "crm command '$cmd' - $task service '$csid' to node '$target'" >> . " (service '$csid' in positive affinity with service '$sid')", >> ); >> - $ss->{$csid}->{cmd} = [$task, $target]; >> + $ss->{$csid}->{cmd} = [$task, $target, $migrate_options]; > > The HA resource affinity rule could contain mixed HA resource types, so > we cannot pass the same $migrate_options to all of them... > > e.g. if ct:100 and vm:101 are in the positive resource affinity rule, > running > > ha-manager migrate vm:101 node2 --with-conntrack-state > > would make the manual migration for ct:100 fail. > > (Though as 'vm:101' is successfully migrated to node2, ct:100 would > automatically be moved to node2 by the HA Manager to make sure the > positive resource affinity rule is fullfilled.) > > > > I'm not sure how to handle this best, as it could be useful if there are > only HA resource of the same type, but at the same time this is quite > implicit right now. Here, I'll just filter out unknown options for the type before passing it along. Will need to make the schema accessible by making migrate_json_properties() a proper plugin method. > The migrateall API endpoint doesn't have the option to set the > --with-conntrack-state option right now for VMs or other shared > parameters such as --bwlimit, etc. There, we could have a schema with all options and do the same, i.e. just pass along the applicable ones to each type? But not going to change that in this series.