From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CE4DB611CB for ; Tue, 8 Feb 2022 14:28:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C528D2F280 for ; Tue, 8 Feb 2022 14:28:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 598832F275 for ; Tue, 8 Feb 2022 14:28:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 35F4E461F5 for ; Tue, 8 Feb 2022 14:22:14 +0100 (CET) Message-ID: Date: Tue, 8 Feb 2022 14:22:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20211022064413.113127-1-d.csapak@proxmox.com> From: Mira Limbeck In-Reply-To: <20211022064413.113127-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.290 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: Re: [pve-devel] [PATCH container] fix #3635: fix pool permission checks on create X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Feb 2022 13:28:12 -0000 On 10/22/21 08:44, Dominik Csapak wrote: > we do not need Permissions.Modify on the pool, so remove it like > we did in > > qemu-server 4fc5242 ("fix pool permission checks on create") > > Signed-off-by: Dominik Csapak > --- > src/PVE/API2/LXC.pm | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm > index 69df366..0ae67a1 100644 > --- a/src/PVE/API2/LXC.pm > +++ b/src/PVE/API2/LXC.pm > @@ -233,7 +233,6 @@ __PACKAGE__->register_method({ > my $pool = extract_param($param, 'pool'); > if (defined($pool)) { > $rpcenv->check_pool_exist($pool); > - $rpcenv->check_perm_modify($authuser, "/pool/$pool"); > } > > if ($rpcenv->check($authuser, "/vms/$vmid", ['VM.Allocate'], 1)) { Works when no Permissions.Modify and no Pool.Allocate permission is set. So consider this: Tested-by: Mira Limbeck