From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E16E669512; Wed, 23 Mar 2022 12:08:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D615E26405; Wed, 23 Mar 2022 12:08:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5ED60263FA; Wed, 23 Mar 2022 12:08:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2854146F70; Wed, 23 Mar 2022 12:08:30 +0100 (CET) Message-ID: Date: Wed, 23 Mar 2022 12:08:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Stefan Sterz , pbs-devel@lists.proxmox.com References: <20220304113202.4137916-1-s.sterz@proxmox.com> <20220304113202.4137916-4-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220304113202.4137916-4-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH proxmox-backup v3 3/6] fix #3607: ui: add a separate notes view for longer markdown notes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Mar 2022 11:08:30 -0000 On 04.03.22 12:31, Stefan Sterz wrote: > since markdown notes might be rather long, this commit adds a tab > similar to pve's datacenter or node notes. > > Signed-off-by: Stefan Sterz > --- > www/Makefile | 2 + > www/NavigationTree.js | 6 ++ > www/NodeNotes.js | 22 +++++++ > www/panel/MarkdownNotes.js | 130 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 160 insertions(+) > create mode 100644 www/NodeNotes.js > create mode 100644 www/panel/MarkdownNotes.js > > diff --git a/www/panel/MarkdownNotes.js b/www/panel/MarkdownNotes.js > new file mode 100644 > index 00000000..6d601401 > --- /dev/null > +++ b/www/panel/MarkdownNotes.js> @@ -0,0 +1,130 @@ > +Ext.define('PBS.panel.MarkdownNotes', { > + extend: 'Ext.panel.Panel', > + xtype: 'pbsMarkdownNotes', > + mixins: ['Proxmox.Mixin.CBind'], > + why add this if we move a almost identical one to widget toolkit? If there are some changes required that cannot be easily passed via a config, we should still reuse most by extending the NotesView wtk component, and not panel.Panel