From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A8F5D68FCD for ; Fri, 11 Mar 2022 10:52:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A23FB2253E for ; Fri, 11 Mar 2022 10:52:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2F78122535 for ; Fri, 11 Mar 2022 10:52:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0126641B1B; Fri, 11 Mar 2022 10:52:47 +0100 (CET) Message-ID: Date: Fri, 11 Mar 2022 10:52:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Matthias Heiserer , Proxmox VE development discussion References: <20220310143137.1384472-1-d.csapak@proxmox.com> From: Dominik Csapak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.153 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH widget-toolkit] StatusView: fix usage calculation for fields without valid values X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 09:52:53 -0000 On 3/11/22 10:13, Matthias Heiserer wrote: > On 10.03.2022 15:31, Dominik Csapak wrote: >> Sometimes, total can be zero (e.g. for swap when it's not used), which >> leads to the usage being NaN. This led to the progressbar not being >> updated for InfoWidgets, leaving a spurious '0%' as text. >> >> Signed-off-by: Dominik Csapak >> --- >>   src/panel/StatusView.js | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/panel/StatusView.js b/src/panel/StatusView.js >> index 4a60dae..e2e81e2 100644 >> --- a/src/panel/StatusView.js >> +++ b/src/panel/StatusView.js >> @@ -47,7 +47,7 @@ Ext.define('Proxmox.panel.StatusView', { >>            */ >>           if (used.used !== undefined && >>           used.total !== undefined) { >> -        return used.used/used.total; >> +        return used.total > 0 ? used.used/used.total : 0; >>           } >>       } > > When used.used or used.total is undefined, the function still returns NaN. Have you considered using > the or operator? that can't happen because of the 'if' check: 'used.used !== undefined && used.total !== undefined'