From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 233069C30E for ; Wed, 31 May 2023 15:19:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 03528A628 for ; Wed, 31 May 2023 15:19:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 31 May 2023 15:19:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C9F0047DBC; Wed, 31 May 2023 15:19:13 +0200 (CEST) Message-ID: Date: Wed, 31 May 2023 15:19:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Alexandre Derumier References: <20230531111952.568734-1-aderumier@odiso.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20230531111952.568734-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.135 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH-SERIES pve-http-server/pve-manager] fix#4689: rewrite_uri: autofind nodename for qemu/lxc X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2023 13:19:15 -0000 On 5/31/23 13:19, Alexandre Derumier wrote: > Hi, > > Currently, to manage qemu && lxc vms, we always need to specify nodename in uri. > > This is a problem with automation tools like terraform, where is node is registered > in the state of terraform. > (That mean, than if we move the vm on another node, terraform don't known it, and try to create the vm > again or can't delete the vm,...) > https://github.com/Telmate/terraform-provider-proxmox/issues/168 > > This can also be a potential problem with race, if we need to query /cluster/ressources to find the node, then another > query on the vm. > > I have some discussion with fabian about it: > https://bugzilla.proxmox.com/show_bug.cgi?id=4689 > > > This patch series, simply find the nodename if not specified and rewrite url. > > /nodes/(qemu|lxc)/ ---> /nodes/// > > > > Alexandre Derumier (1): > anyevent: add rewrite_uri > > src/PVE/APIServer/AnyEvent.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > Alexandre Derumier (1): > httpserver: add rewrite uri for /nodes/(qemu/lxc)/ > > PVE/HTTPServer.pm | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > hi, while this can work, it introduces a very specific rewriting into the http server, which might not be obvious and AFAICT won't show up in the auto-generated api docs? wouldn't it be better to have some api calls defined for real (the ones used most often for example) that make use of the proxyto_callback method instead? that way they would at least show up in the api documentation, even though it's probably a bit of code duplication (altough we could maybe just insert the api at a different place and do some perl magic refactoring to have it once with node parameter and once without?) or does that seem like a bad idea?