From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7C6021FF16F for ; Thu, 30 Jan 2025 13:17:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AD1E010803; Thu, 30 Jan 2025 13:17:50 +0100 (CET) Message-ID: Date: Thu, 30 Jan 2025 13:17:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Filip Schauer References: <20250129155339.164696-1-f.schauer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250129155339.164696-1-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster/guest-common/manager/qemu-server v2 0/9] fix #5657: allow configuring RNG device as non-root user X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 29.01.25 um 16:53 schrieb Filip Schauer: > Allow users with the VM.Config.HWType privilege to configure VirtIO RNG > devices on VMs with either /dev/urandom or /dev/random as the entropy > source. > > Further introduce hardware RNG device mapping to be able to selectively > allow non-root users with the Mapping.Use privilege to configure > hardware RNG devices as entropy sources. > It's a lot of overhead for a very specific kind of device. What irks me is that we have a lot of boilerplate duplication for each new mapping type, also for the API endpoints. Nothing specific to your series of course, but maybe something we could/should address? In the UI, it probably would also be better to have a separate view for each mapping type? Markus needs directory mappings for virtio-fs and then we would have 4 different mapping kinds in a single view, which IMHO is just too much. Maybe we can introduce a dedicated base module for Mapping Section configs? And also have standard options for the common params in the schema. Same applies for the API endpoints, would be nice to have a way to more easily generate them or at least capture the functionality that is 1:1 with some helpers. Again, nothing specific to your series. Just putting it out there for discussion or if somebody wants to grab that task :) When I try to add a mapping in the UI, I get Parameter verification failed. (400) map: type check ('array') failed _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel