From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 419491FF183 for ; Wed, 2 Jul 2025 15:42:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 091741C012; Wed, 2 Jul 2025 15:42:47 +0200 (CEST) Message-ID: Date: Wed, 2 Jul 2025 15:42:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Christoph Heiss References: <20250630112615.1007598-1-c.heiss@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20250630112615.1007598-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.681 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.232 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-firewall.rs, proxmox.com] Subject: Re: [pve-devel] [PATCH proxmox-firewall] firewall: show full error if rule apply fails X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 6/30/25 13:23, Christoph Heiss wrote: > Currently, this will only log something like > > error updating firewall rules: cannot execute nftables commands > > which, by itself, is pretty unhelpful. `anyhow` errors have context, so > show that too. How much additional lines in the log would that be? Since the daemon runs every 5s this could grow large quite quickly. I already made some effort of improving the debug experience by introducing new subcommands [1], similar to pve-firewall. So potentially that is sufficient? Otherwise we could also make this dependent on the log level? [1] https://lore.proxmox.com/pve-devel/20250527135800.190084-3-s.hanreich@proxmox.com/ > Signed-off-by: Christoph Heiss > --- > proxmox-firewall/src/bin/proxmox-firewall.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proxmox-firewall/src/bin/proxmox-firewall.rs b/proxmox-firewall/src/bin/proxmox-firewall.rs > index 4732e51..5cd0c70 100644 > --- a/proxmox-firewall/src/bin/proxmox-firewall.rs > +++ b/proxmox-firewall/src/bin/proxmox-firewall.rs > @@ -101,7 +101,7 @@ fn main() -> Result<(), std::io::Error> { > let start = Instant::now(); > > if let Err(error) = handle_firewall() { > - log::error!("error updating firewall rules: {error}"); > + log::error!("error updating firewall rules: {error:#}"); > } > > let duration = start.elapsed(); _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel