From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 21A8A9686D for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:46:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 08D2317484 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:46:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:46:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1E99F45472 for <pve-devel@lists.proxmox.com>; Tue, 16 Apr 2024 11:46:05 +0200 (CEST) Message-ID: <ed97ad51-73fa-467a-a93e-899ef3da642d@proxmox.com> Date: Tue, 16 Apr 2024 11:46:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> References: <20240307090000.139143-1-f.gruenbichler@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20240307090000.139143-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.221 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-ve] apt hook: disable on remove X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 16 Apr 2024 09:46:36 -0000 Am 07.03.24 um 10:00 schrieb Fabian Grünbichler: > and (re-)enable on install. adapted from apt-listbugs/apt-listchanges, which > solve the issue of removing (instead of purging) the package keeping the > conffile while removing the hook binary in the same fashion. > Suggested-by: Fiona Ebner <f.ebner@proxmox.com> > Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> With my comment below addressed: Reviewed-by: Fiona Ebner <f.ebner@proxmox.com> > --- > tested with: > - touch /please-remove-proxmox-ve > - remove proxmox-ve (works, hook config moved out of the way) > - purge proxmox-ve (works, disabled config removed) > - reinstall proxmox-ve (works, hook config reappears) > > - touch /please-remove-proxmox-ve > - remove (works, hook config moved out of the way) > - reinstall (works, hook config reappears) > > - touch /please-remove-proxmox-ve > - purge proxmox-ve (works, hook config removed) > - reinstall (works, hook config reappears) > > debian/proxmox-ve.postrm | 33 +++++++++++++++++++++++++++++++++ > debian/proxmox-ve.preinst | 13 +++++++++++++ > 2 files changed, 46 insertions(+) > create mode 100644 debian/proxmox-ve.postrm > create mode 100644 debian/proxmox-ve.preinst > > diff --git a/debian/proxmox-ve.postrm b/debian/proxmox-ve.postrm > new file mode 100644 > index 0000000..f3eff33 > --- /dev/null > +++ b/debian/proxmox-ve.postrm > @@ -0,0 +1,33 @@ > +#! /bin/sh > +set -e > + > +hook=/etc/apt/apt.conf.d/10pveapthook > + > +case "$1" in > + purge) > + rm -f $hook.disabled > + ;; > + > + remove) We should check for existence first. While we don't expect the hook to be missing, it could be for whatever reason and then both 'apt purge' and 'apt remove' would fail. > + mv $hook $hook.disabled > + ;; > + > + abort-install) > + if test "x$2" != "x" && test -f $hook > + then > + mv $hook $hook.disabled > + fi > + ;; > + > + upgrade|failed-upgrade|abort-upgrade|disappear) > + ;; > + > + *) > + echo "postrm called with unknown argument \`$1'" >&2 > + exit 1 > + > +esac > + > +#DEBHELPER# > + > +exit 0