From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DBEA460626 for ; Tue, 17 Nov 2020 13:43:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C3E7210142 for ; Tue, 17 Nov 2020 13:43:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A5EF710136 for ; Tue, 17 Nov 2020 13:43:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 763BC435E4 for ; Tue, 17 Nov 2020 13:43:13 +0100 (CET) To: Dominik Csapak , Proxmox VE development discussion References: <20201102140102.26141-1-a.lauterer@proxmox.com> <20201102140102.26141-2-a.lauterer@proxmox.com> <93892863-6465-7443-4881-5daa3cccc43a@proxmox.com> <39d726dc-ca26-69e6-75d9-21c6363c4b21@proxmox.com> From: Aaron Lauterer Message-ID: Date: Tue, 17 Nov 2020 13:43:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <39d726dc-ca26-69e6-75d9-21c6363c4b21@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.005 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH widget-toolkit v2] InputPanel: fix column scaling behavior X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 12:43:44 -0000 On 11/17/20 1:05 PM, Dominik Csapak wrote: > On 11/17/20 12:41 PM, Aaron Lauterer wrote: >> >> >> On 11/17/20 10:29 AM, Dominik Csapak wrote: >>> some comments inline, looks good otherwise >>> >>> On 11/2/20 3:01 PM, Aaron Lauterer wrote: >>>> When scaling the browsers content either via the browser itself or [...] >>>> +            layout: 'hbox', >>>> +            defaults: { >>>> +            border: false, >>>> +            }, >>> >>> i guess we could add >>> >>> layout: 'anchor' >>> >>> here too and save 3 lines? >> >> instead of the hbox and disabling borders for the 4column layout? >> >> Doesn't work for me on Firefox when I do that and check against the PMG -> Configuration -> Spam Detector -> Options -> Languages panel >> > > hmm? i meant adding using > > layout: 'hbox', > defaults: { >     border: false, >     layout: 'anchor', >     flex: 1, > }, > > (i just noticed we could also set 'flex: 1' there) > instead of adding layout: 'anchor' on every child > 'defaults' corresponds to the default settings of all child items > ah now I get it. Yep seems to be working. I will send in v3 with those changes [...] >>>>           defaults: { >>>>               border: false, >>>>           }, >>> >>> i guess we would have to change this here to vbox as well? >>> do we even use 'fieldContainer' anywhere anymore? >> >> There are a few places where we have >> >> xtype: 'fieldcontainer', >> extend: 'Ext.form.FieldContainer', > > thats something different thanks for confirming that > >> >> if you grep the widget toolkit, pmg-gui and pve-manager repos, but nothing where we set >> >> me.useFieldContainer >> >> manually. Unless that is some property that extjs is setting automagically. > > i cannot remember, but a short search in extjs source does > not turn anything up for 'useFieldContainer' so i'd > say this is dead code and we should/could remove it altogether... > (i also quickly grepped proxmox-backup, but no use of it there either) > I'll add a separate commit on the v3 to remove that code