From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 687429536E for ; Fri, 12 Apr 2024 10:38:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4898866DB for ; Fri, 12 Apr 2024 10:38:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 12 Apr 2024 10:38:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5A5CB44FA0 for ; Fri, 12 Apr 2024 10:38:19 +0200 (CEST) Message-ID: Date: Fri, 12 Apr 2024 10:38:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20240411092943.57377-1-f.ebner@proxmox.com> <20240411092943.57377-10-f.ebner@proxmox.com> <78415bc5-12bc-400e-9734-ee89023c4e72@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <78415bc5-12bc-400e-9734-ee89023c4e72@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: Re: [PATCH guest-common v3 09/22] vzdump: schema: add fleecing property string X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2024 08:38:20 -0000 Am 11.04.24 um 20:07 schrieb Thomas Lamprecht: > On 11/04/2024 11:29, Fiona Ebner wrote: >> It's a property string, because that avoids having an implicit >> "enabled" as part of a 'fleecing-storage' property. And there likely >> will be more options in the future, e.g. threshold/limit for the >> fleecing image size. >> >> Storage is non-optional, so the storage choice needs to be a conscious >> decision. Can allow for a default later, when a good choice can be >> made further down the stack. The original idea with "same storage as >> VM disk" is not great, because e.g. for LVM, it would require the same >> size as the disk up front. >> >> Signed-off-by: Fiona Ebner >> --- >> src/PVE/VZDump/Common.pm | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> > > applied, but massaged in having the whitespace on the continued line for > multi-line strings, not on the previous (we should actually add that to > the style guide), thanks! Sorry, I always forget the preferred way. Added to the style guide now: https://pve.proxmox.com/wiki/Perl_Style_Guide#Wrapping_Strings