From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 170D57607C for ; Thu, 22 Apr 2021 20:38:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1410820A48 for ; Thu, 22 Apr 2021 20:38:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2A81420A3A for ; Thu, 22 Apr 2021 20:38:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EFC5A46366 for ; Thu, 22 Apr 2021 20:38:33 +0200 (CEST) Message-ID: Date: Thu, 22 Apr 2021 20:38:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210419110048.20791-1-d.csapak@proxmox.com> <20210419110048.20791-5-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210419110048.20791-5-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit 4/4] panel: add StatusView from PVE X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2021 18:38:35 -0000 On 19.04.21 13:00, Dominik Csapak wrote: > with 2 minor fixups: > * one lint error > * binding of the 'updateValues' function in the event > (we want to avoid breaking this when used in a context where > a controller exists, in that case using a string will only look in > the controller and not in the component itself anymore, so use > the function directly) > > Signed-off-by: Dominik Csapak > --- > src/Makefile | 1 + > src/panel/StatusView.js | 125 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 126 insertions(+) > create mode 100644 src/panel/StatusView.js applied, with a some unimportant cleanups and an important fix (or better said, workaround) for the use in PVE, see below. > diff --git a/src/panel/StatusView.js b/src/panel/StatusView.js > new file mode 100644 > index 0000000..059508a > --- /dev/null > +++ b/src/panel/StatusView.js > + updateValues: function(store, records, success) { > + if (!success) { > + return; // do not update if store load was not successful > + } > + var me = this; > + var itemsToUpdate = me.query('pmxInfoWidget'); does not finds the pveInfoWidgets from, well, PVE, and makes for a pretty boring view there ;-) > + > + itemsToUpdate.forEach(me.updateField, me); > + > + me.updateTitle(store); > + }, > +