From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 4D9347734D
 for <pve-devel@lists.proxmox.com>; Thu, 21 Oct 2021 16:21:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 441BD1FDDE
 for <pve-devel@lists.proxmox.com>; Thu, 21 Oct 2021 16:21:14 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id B4F401FDD0
 for <pve-devel@lists.proxmox.com>; Thu, 21 Oct 2021 16:21:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 89D0A4550F;
 Thu, 21 Oct 2021 16:21:13 +0200 (CEST)
Message-ID: <eb987813-d31a-7b9e-2746-4cf92b3b3428@proxmox.com>
Date: Thu, 21 Oct 2021 16:21:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101
 Thunderbird/94.0
Content-Language: en-US
To: Oguz Bektas <o.bektas@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20211012112052.437232-1-d.csapak@proxmox.com>
 <YXE4kFF4pmA76Zen@gaia> <48b2b9ed-4c92-4160-004e-49fe2920e50b@proxmox.com>
 <YXFSdgYbOtRDi/+A@gaia>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <YXFSdgYbOtRDi/+A@gaia>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.414 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -2.267 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server] fix removing cpulimit on
 running vm
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 21 Oct 2021 14:21:14 -0000

On 10/21/21 13:43, Oguz Bektas wrote:
> On Thu, Oct 21, 2021 at 12:51:43PM +0200, Dominik Csapak wrote:
>> On 10/21/21 11:53, Oguz Bektas wrote:
>>> hi,
>>>
>>> works for cgroupv2 but with 'systemd.unified_cgroup_hierarchy=0' in
>>> cmdline it errors:
>>>
>>>
>>> ====
>>> update VM 101: -delete cpulimit
>>> 400 Parameter verification failed.
>>> cpulimit: hotplug problem - closing file
>>> '/sys/fs/cgroup/cpu/qemu.slice/101.scope//cpu.cfs_period_us' failed -
>>> Invalid argument
>>> ====
>>>
>>>
>>
>> hm... does this work for running containers? since we use the
>> exact same code there for cpulimit...
> 
> apparently doesn't work there either
> 

ok i guess then we should fix it in pve-common and keep this patch as is?