From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 27C9A93D3F for ; Wed, 22 Feb 2023 16:19:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 009641A7A9 for ; Wed, 22 Feb 2023 16:18:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 22 Feb 2023 16:18:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 294164815C; Wed, 22 Feb 2023 16:18:42 +0100 (CET) Message-ID: Date: Wed, 22 Feb 2023 16:18:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Fiona Ebner To: Proxmox VE development discussion , Alexandre Derumier References: <20230213120021.3783742-1-aderumier@odiso.com> <20230213120021.3783742-9-aderumier@odiso.com> Content-Language: en-US In-Reply-To: <20230213120021.3783742-9-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.095 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v4 qemu-server 08/16] config: memory: add 'max' option X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2023 15:19:13 -0000 Am 13.02.23 um 13:00 schrieb Alexandre Derumier: > diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm > index 32fbdc5..deeb88f 100644 > --- a/PVE/QemuServer/Memory.pm > +++ b/PVE/QemuServer/Memory.pm > @@ -3,8 +3,10 @@ package PVE::QemuServer::Memory; > use strict; > use warnings; > > +use PVE::JSONSchema; > use PVE::Tools qw(run_command lock_file lock_file_full file_read_firstline dir_glob_foreach); > use PVE::Exception qw(raise raise_param_exc); > +use PVE::GuestHelpers qw(safe_string_ne safe_num_ne safe_boolean_ne); Stlye nit: pre-existing, but now it's even less sorted alphabetically. Also, you don't use safe_string_ne so no need to import (and safe_boolean_ne should be imported by the patch that uses it). > > use PVE::QemuServer; > use PVE::QemuServer::Monitor qw(mon_cmd); > @@ -25,8 +27,26 @@ our $memory_fmt = { > minimum => 16, > default => 512, > }, > + max => { Really could use a description, so that users know that it's used for hotplug. > + type => 'integer', > + optional => 1, > + minimum => 65536, > + maximum => 4194304, > + format => 'pve-qm-memory-max', > + }, > }; > > +PVE::JSONSchema::register_format('pve-qm-memory-max', \&verify_qm_memory_max); > +sub verify_qm_memory_max { > + my ($max, $noerr) = @_; > + > + return if $noerr; $noerr only switches if the function should die upon error or return undef upon error. But if there is no error, you always need to return the verified value, i.e. $max. > + > + die "max memory need to be a multiple of 64GiB\n" if $max && $max % 65536 != 0; > + > + return $max > +} > + > sub print_memory { > my $memory = shift; >