From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 829C39F524 for ; Mon, 6 Nov 2023 09:30:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5DC3E12D4D for ; Mon, 6 Nov 2023 09:30:02 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 6 Nov 2023 09:30:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2175545230; Mon, 6 Nov 2023 09:30:01 +0100 (CET) Message-ID: Date: Mon, 6 Nov 2023 09:30:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Content-Language: en-US From: Dominik Csapak To: Thomas Lamprecht , Proxmox VE development discussion Reply-To: Proxmox VE development discussion References: <20231103115343.4133611-1-d.csapak@proxmox.com> <2cd139da-fe1b-4709-881a-603ea5de8427@proxmox.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC PATCH cluster/guest-common/qemu-server/container/manager] add backend profile support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2023 08:30:32 -0000 small correction inline: On 11/6/23 09:17, Dominik Csapak wrote: [snip] >>> We could also go in a completely different direction and create a config >>> per profile? (like we handle vm configs). Downside of that is, that the >>> current guest config handling part is partly in pmxcfs, so we'd have to >>> make that either more generic, or duplicate it for profiles. >> >> I don't see how this would have anything to do with pmxcfs and VMIDs, >> that map to an actual guest instance and thus needs special treatment >> compared to just some profile that can, e.g., live in a >> /etc/pve/guest-profiles/  as .profile (the extension just an >> example), and be handled only via perl – profiles are only used in >> the profile management API, where it's ok to fully parse one, and >> in guest creation POST calls, so even cfs_register* would be probably >> overkill. > > you're right, i did not explain right what i meant. We currently do > somethings in pmxcfs for vm configs (e.g. read/write/list) and i don't mean ofc that the read/write itself is implemented in pmxcfs, but is special handled in pve-cluster (e.g. by registering '/qemu-server/' as the file). The parser/writer is still perl.. sry for the bad wording